Fix refs in vars in projects being rendered (#1047) #1048
Merged
+34
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Oct 12, 2018
There was a problem hiding this comment.
This LGTM. I kind of like this idea:
An alternative to consider: should nothing under models/seeds get rendered until execution time?
I'm trying to enumerate all of the things that can be configured for models and seeds. The only thing I can imagine would be problematic is the enabled: config. If a model is disabled, then the actual shape of the graph is different, and it's unclear to me if there would be any negative impact of delaying the rendering until execution time.
|
Fixes #1047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1035 I added logic that uses jinja to render all fields with a context containing vars/env_vars. This was a mistake, since apparently you can ref() models in there, and rendering will always fail if you do that.
I also added a test that reproduces the issue.
An alternative to consider: should nothing under models/seeds get rendered until execution time?